7 comments:
File src/soc/mediatek/mt8192/gpio.c:
Patch Set #1, Line 20: static void* gpio_find_reg_addr(gpio_t gpio)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 23: switch(gpio.base & 0x0f) {
switch and case should be at the same indent
Patch Set #1, Line 23: switch(gpio.base & 0x0f) {
space required before the open parenthesis '('
File src/soc/mediatek/mt8192/include/soc/gpio.h:
Patch Set #1, Line 29: #define PIN(id, name, flag, bit, base, offset, \
Macros with complex values should be enclosed in parentheses
Patch Set #1, Line 184: MD_INT2_C2K_UIM1_HOT_PLUG, SCL_6306, ADSP_URXD0, PTA_RXD, SSPM_URXD_AO, DBG_MON_B0),
line over 96 characters
Patch Set #1, Line 214: CONN_MCU_AICE_TMSC, , RES6, RES7),
space prohibited before that ',' (ctx:WxW)
Patch Set #1, Line 224: PIN(57,MIPI2_D_SCLK, 0, 1, 0x22, 0x80,
space required after that ',' (ctx:VxV)
To view, visit change 43959. To unsubscribe, or for help writing mail filters, visit settings.