Attention is currently required from: Paul Menzel, Angel Pons.
Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46832 )
Change subject: autoport: Add Broadwell SoC support
......................................................................
Patch Set 10:
(1 comment)
File util/autoport/wildcatpoint.go:
https://review.coreboot.org/c/coreboot/+/46832/comment/c53a16a4_02ed6a71
PS9, Line 148: /* FIXME: check these values */
: pei_data->dimm_channel0_disabled = 0;
: pei_data->dimm_channel1_disabled = 0;
: pei_data->spd_addresses[0] = 0xa0;
: pei_data->spd_addresses[1] = 0xa2;
: pei_data->spd_addresses[2] = 0xa4;
: pei_data->spd_addresses[3] = 0xa6;
Broadwell ULT/ULX only supports 1 DIMM per channel. I'd just write: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62ab51b8a9c5873695bd7d75543c452ec422f11d
Gerrit-Change-Number: 46832
Gerrit-PatchSet: 10
Gerrit-Owner: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Juanita Harvey
juanitalynn969@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 29 Sep 2021 14:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment