Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38075 )
Change subject: mb/foxconn/d41s/devicetree.cb: Indent with tabs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38075/1/src/mainboard/foxconn/d41s/... File src/mainboard/foxconn/d41s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38075/1/src/mainboard/foxconn/d41s/... PS1, Line 52: device pci 00.0 on end
[out of topic] what is the difference between this and the one at line #30 please ?
It's in a different location / on a different bus. 1c.1 is the bridge, it will get a secondary bus number assigned, e.g. 2, so this devices would be 0000:02:00.0. While the one above will always be 0000:00:00.0.
Strictly speaking, the entry here is not necessary, btw. It's neither asso- ciated with a driver (chip) nor does it provide any information beyond the `on` which is the default. It results in a warning, though, if the device is failing.