31 Dec
2019
31 Dec
'19
3:24 p.m.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )
Change subject: nb/agesa/family14: Remove wrong _ADR ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... PS2, Line 131:
Why removing _ADR? (_HID is not defined and no other _ADR)
_HID is defined under ThermalZone included with thermal_mixin.asl
Secondly, do thermal zones even require _HID? The specification doesn't say it is required or optional.
--
To view, visit https://review.coreboot.org/c/coreboot/+/38014
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c
Gerrit-Change-Number: 38014
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Frans Hendriks fhendriks@eltan.com
Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Tue, 31 Dec 2019 14:24:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Gerrit-MessageType: comment