Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46503 )
Change subject: soc/intel/xeon_sp/cpx/acpi: Align MADT IO APIC ID's with DMAR ......................................................................
Patch Set 2:
(2 comments)
Thanks for fixing this, Arthur. I added some minor comments.
https://review.coreboot.org/c/coreboot/+/46503/2/src/soc/intel/xeon_sp/cpx/a... File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/46503/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 87: const int gsi_bases[] = { 0, 0x78, 0x80, 0x88, 0x90, 0x98, 0xA0, 0xA8, 0xB0 }; It would be good to increase gsi_bases[] to match the number of IOAPICs, to take care of 2 socket case.
https://review.coreboot.org/c/coreboot/+/46503/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 129: current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, It would be good to add a print statement here to facilitate debugging.