Thanks for fixing this, Arthur.
I added some minor comments.

View Change

2 comments:

• File src/soc/intel/xeon_sp/cpx/acpi.c:

  • Patch Set #2, Line 87: const int gsi_bases[] = { 0, 0x78, 0x80, 0x88, 0x90, 0x98, 0xA0, 0xA8, 0xB0 };

    It would be good to increase gsi_bases[] to match the number of IOAPICs, to take care of 2 socket case.

  • Patch Set #2, Line 129: current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current,

    It would be good to add a print statement here to facilitate debugging.

To view, visit change 46503. To unsubscribe, or for help writing mail filters, visit settings.