Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33504 )
Change subject: MSR: Move common intel's MSRs to common place
......................................................................
Patch Set 4:
(1 comment)
FYI: I see little value here and wont be doing any proper review.
You should not push MSR register definitions that do not apply to all intel CPU models into a common file cpu/intel/msr.h.
https://review.coreboot.org/#/c/33504/4/src/include/cpu/intel/msr.h
File src/include/cpu/intel/msr.h:
https://review.coreboot.org/#/c/33504/4/src/include/cpu/intel/msr.h@20
PS4, Line 20: #define MSR_PLATFORM_INFO 0xce
This, for example, is not defined for all Intel models.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33504
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45cd255e0af4369926a6cb884be9ee71bf1a66de
Gerrit-Change-Number: 33504
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 01 Jul 2019 16:28:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment