FYI: I see little value here and wont be doing any proper review.

You should not push MSR register definitions that do not apply to all intel CPU models into a common file cpu/intel/msr.h.

View Change

1 comment:

• File src/include/cpu/intel/msr.h:

  • Patch Set #4, Line 20: #define MSR_PLATFORM_INFO 0xce

    This, for example, is not defined for all Intel models.

To view, visit change 33504. To unsubscribe, or for help writing mail filters, visit settings.