Attention is currently required from: Noga Smith, Tarun Tuli, Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Kapil Porwal, Angel Pons, Nick Vaccaro, Raj Astekar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63364 )
Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till ramstage ......................................................................
Patch Set 22: Verified+1
(24 comments)
File src/soc/intel/meteorlake/acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/1eb2f4a2_2d8258e6 PS22, Line 180: printk(BIOS_DEBUG, "%s - gfxvtbar:0x%llx 0x%x \n", __func__, gfxvtbar, MCHBAR32(GFXVTBAR)); line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/e3bf042e_596b6f89 PS22, Line 180: printk(BIOS_DEBUG, "%s - gfxvtbar:0x%llx 0x%x \n", __func__, gfxvtbar, MCHBAR32(GFXVTBAR)); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/f61201ee_3bc38366 PS22, Line 201: if (is_dev_enabled(igfx_dev) && gfxvtbar && gfxvten ) { space prohibited before that close parenthesis ')'
File src/soc/intel/meteorlake/cpu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/75ffbfc7_82b3f434 PS22, Line 36: case MTLM: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File src/soc/intel/meteorlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/a077d52f_19fb2e0e PS22, Line 336: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite() code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/b77ebdb9_3a9ce7b1 PS22, Line 336: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite() please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/734d78fc_0cae1664 PS22, Line 337: && vboot_recovery_mode_enabled() && !cse_is_hfs1_com_normal()) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/2c69dcda_79b9c3c8 PS22, Line 337: && vboot_recovery_mode_enabled() && !cse_is_hfs1_com_normal()) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/df32d5b2_c4b6523f PS22, Line 338: /* code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/d1cc65d4_08fda194 PS22, Line 339: * CSE Lite SKU does not support hybrid storage dynamic configuration code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/7716b391_06a5f840 PS22, Line 340: * in CSE RO boot, and FSP does not allow to send the strap override code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/6b160d65_69176d10 PS22, Line 341: * HECI commands if CSE is not in normal mode; hence, hybrid storage code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/ddd478f4_48ef0475 PS22, Line 342: * mode is disabled on CSE RO boot in recovery boot mode. code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/b7a8d398_cec1656b PS22, Line 343: */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/9a230297_977e292e PS22, Line 344: printk(BIOS_INFO, "cse_lite: CSE RO boot. HybridStorageMode disabled\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/03393bc2_5a417c82 PS22, Line 344: printk(BIOS_INFO, "cse_lite: CSE RO boot. HybridStorageMode disabled\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/2ae9582c_33ab4e9a PS22, Line 345: s_cfg->HybridStorageMode = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/6f3d878d_c1b3d7b6 PS22, Line 345: s_cfg->HybridStorageMode = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/9b8c7933_d0582ff2 PS22, Line 346: } else { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/6b1a00cc_82a9be82 PS22, Line 346: } else { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/a7373d0f_ec2e32e1 PS22, Line 347: s_cfg->HybridStorageMode = config->HybridStorageMode; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/2e1ad5d7_3906f7a0 PS22, Line 347: s_cfg->HybridStorageMode = config->HybridStorageMode; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/83082ec9_25a82d61 PS22, Line 348: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493): https://review.coreboot.org/c/coreboot/+/63364/comment/43724cf8_1dbb8cc6 PS22, Line 348: } please, no spaces at the start of a line