Attention is currently required from: Noga Smith, Tarun Tuli, Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Kapil Porwal, Angel Pons, Nick Vaccaro, Raj Astekar.

Patch set 22:Verified +1

View Change

24 comments:

• File src/soc/intel/meteorlake/acpi.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 180: printk(BIOS_DEBUG, "%s - gfxvtbar:0x%llx 0x%x \n", __func__, gfxvtbar, MCHBAR32(GFXVTBAR));

    line length of 100 exceeds 96 columns

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 180: printk(BIOS_DEBUG, "%s - gfxvtbar:0x%llx 0x%x \n", __func__, gfxvtbar, MCHBAR32(GFXVTBAR));

    unnecessary whitespace before a quoted newline

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 201: if (is_dev_enabled(igfx_dev) && gfxvtbar && gfxvten ) {

    space prohibited before that close parenthesis ')'

• File src/soc/intel/meteorlake/cpu.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 36: case MTLM: /* fallthrough */

    Prefer 'fallthrough;' over fallthrough comment

• File src/soc/intel/meteorlake/fsp_params.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 336: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite()

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 336: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_hfs3_fw_sku_lite()

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 337: && vboot_recovery_mode_enabled() && !cse_is_hfs1_com_normal()) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 337: && vboot_recovery_mode_enabled() && !cse_is_hfs1_com_normal()) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 338: /*

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 339: * CSE Lite SKU does not support hybrid storage dynamic configuration

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 340: * in CSE RO boot, and FSP does not allow to send the strap override

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 341: * HECI commands if CSE is not in normal mode; hence, hybrid storage

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 342: * mode is disabled on CSE RO boot in recovery boot mode.

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 343: */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 344: printk(BIOS_INFO, "cse_lite: CSE RO boot. HybridStorageMode disabled\n");

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 344: printk(BIOS_INFO, "cse_lite: CSE RO boot. HybridStorageMode disabled\n");

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 345: s_cfg->HybridStorageMode = 0;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 345: s_cfg->HybridStorageMode = 0;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 346: } else {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 346: } else {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 347: s_cfg->HybridStorageMode = config->HybridStorageMode;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 347: s_cfg->HybridStorageMode = config->HybridStorageMode;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 348: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150493):

    Patch Set #22, Line 348: }

    please, no spaces at the start of a line

To view, visit change 63364. To unsubscribe, or for help writing mail filters, visit settings.