build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 76:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35523/76/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35523/76/src/mainboard/acer/aspire_... PS76, Line 34: In that scenario, "Select PCIE card" (which controls the active state of PWR_EN) line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/76/src/mainboard/acer/aspire_... PS76, Line 43: gpio_set(DGPU_PWR_EN, 1); // Peg Eval: PWR_EN ActiveHigh; Elk Creek 4: PWR_EN ActiveLow line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/76/src/mainboard/acer/aspire_... PS76, Line 45: /* TODO: For the moment, simply notify the user. Otherwise: delay or wait for PWROK? */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/76/src/mainboard/acer/aspire_... PS76, Line 46: if (!gpio_get(DGPU_PWROK)) { braces {} are not necessary for single statement blocks