Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38300 )
Change subject: timestamps: Fix TIMESTAMPS_ON_CONSOLE behaviour ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38300/1/src/lib/timestamp.c File src/lib/timestamp.c:
https://review.coreboot.org/c/coreboot/+/38300/1/src/lib/timestamp.c@131 PS1, Line 131: tse->entry_stamp = ts_time - ts_table->base_time; If I visualize this correctly, timestamps prior to CBMEM coming online will have ts_table->base_time subtracted twice?
https://review.coreboot.org/c/coreboot/+/38300/1/src/lib/timestamp.c@154 PS1, Line 154: printk(BIOS_INFO, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time); If we define this to show raw/absolute timestamp, we could print this in !ts_table case too, and move up a couple lines. It is currently confusing that cbmem -c and cbmem -t will not have same output due to ts_table->base_time.