Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35456 )
Change subject: [RFC] sconfig: Allow to give static device nodes a name ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35456/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35456/1//COMMIT_MSG@16 PS1, Line 16: _static_serial_eeprom What are your thoughts in promoting the name defined in devicetree as a global symbol w/o the hierarchy information? My concern is around having multiples of certain things and then we have something1 and something2 and those symbols baked into the code.
When should someone use the 1 variant vs the 2 variant? Should we allow common code (soc/) changes to refer to names in mainboard devicetrees?
Do you envision this approach proliferating?
https://review.coreboot.org/c/coreboot/+/35456/1/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/35456/1/util/sconfig/main.c@1410 PS1, Line 1410: outputf[strlen(outputf) - 1] = 'h'; Looks like this patch is also making a new file. Could you please mention that in the description as well?