View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 16: _static_serial_eeprom

    What are your thoughts in promoting the name defined in devicetree as a global symbol w/o the hierarchy information? My concern is around having multiples of certain things and then we have something1 and something2 and those symbols baked into the code.

    When should someone use the 1 variant vs the 2 variant?
    Should we allow common code (soc/) changes to refer to names in mainboard devicetrees?

    Do you envision this approach proliferating?

• File util/sconfig/main.c:

  • Patch Set #1, Line 1410: outputf[strlen(outputf) - 1] = 'h';

    Looks like this patch is also making a new file. Could you please mention that in the description as well?

To view, visit change 35456. To unsubscribe, or for help writing mail filters, visit settings.