John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42953 )
Change subject: mb/intel/tglrvp: Add PMC.MUX.CONx devices to devicetree for tglrvp_up3
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42953/4/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42953/4/src/mainboard/intel/tglrvp/...
PS4, Line 266: TYPEC_ORIENTATION_NORMAL
just to check, this board has retimers that fix the orientation of the SBU signals?
yes, it has retimers for all ports.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7210e00cebe16a5fb8417ac23abad98e574e0982
Gerrit-Change-Number: 42953
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Jul 2020 17:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment