Attention is currently required from: Máté Kukri, Maxim Polyakov, Tristan Corrick, Angel Pons, Arthur Heymans.
Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform
......................................................................
Patch Set 33:
(4 comments)
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/c2e8d251_d0db8ae7
PS1, Line 272: RestoreDIRRoute(sb, "D31IR", uint16(inteltool.RCBA[0x3140]))
: RestoreDIRRoute(sb, "D29IR", uint16(inteltool.RCBA[0x3144]))
: RestoreDIRRoute(sb, "D28IR", uint16(inteltool.RCBA[0x3146]))
: RestoreDIRRoute(sb, "D27IR", uint16(inteltool.RCBA[0x3148]))
: RestoreDIRRoute(sb, "D26IR", uint16(inteltool.RCBA[0x314c]))
: RestoreDIRRoute(sb, "D25IR", uint16(inteltool.RCBA[0x3150]))
: RestoreDIRRoute(sb, "D22IR", uint16(inteltool.RCBA[0x315c]))
: RestoreDIRRoute(sb, "D20IR", uint16(inteltool.RCBA[0x3160]))
DxxIR and DxxIP are only useful to support legacy interrupt routing. I'm […]
Removed.
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/f077b1dc_6c0afe06
PS32, Line 199: lvl = "LOW"
+1
Done
https://review.coreboot.org/c/coreboot/+/30890/comment/4141ed9d_26568c21
PS32, Line 201: lvl = "HIGH"
fmt. […]
Done
https://review.coreboot.org/c/coreboot/+/30890/comment/bf791e19_c48f024a
PS32, Line 536: !isULT
I'd flip the if/else branches to avoid the negation in the condition
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f6e8c97b5122101de2f36bba8ba9f8ddd5b813a
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 33
Gerrit-Owner: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Jamal Wright
Crabstorage@getbackinthe.kitchen
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Pablo Stebler
pablo@stebler.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska
github@slrie.de
Gerrit-CC: Máté Kukri
kukri.mate@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 29 Sep 2021 13:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Corrick
tristan@corrick.kiwi
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Iru Cai
mytbk920423@gmail.com
Gerrit-MessageType: comment