Attention is currently required from: Máté Kukri, Maxim Polyakov, Tristan Corrick, Angel Pons, Arthur Heymans.

View Change

4 comments:

• File util/autoport/lynxpoint.go:

  • Patch Set #1, Line 272:

    RestoreDIRRoute(sb, "D31IR", uint16(inteltool.RCBA[0x3140]))
    	RestoreDIRRoute(sb, "D29IR", uint16(inteltool.RCBA[0x3144]))
    	RestoreDIRRoute(sb, "D28IR", uint16(inteltool.RCBA[0x3146]))
    	RestoreDIRRoute(sb, "D27IR", uint16(inteltool.RCBA[0x3148]))
    	RestoreDIRRoute(sb, "D26IR", uint16(inteltool.RCBA[0x314c]))
    	RestoreDIRRoute(sb, "D25IR", uint16(inteltool.RCBA[0x3150]))
    	RestoreDIRRoute(sb, "D22IR", uint16(inteltool.RCBA[0x315c]))
    	RestoreDIRRoute(sb, "D20IR", uint16(inteltool.RCBA[0x3160]))
    

    > DxxIR and DxxIP are only useful to support legacy interrupt routing. I'm […]

    Removed.

• File util/autoport/lynxpoint.go:

  • Patch Set #32, Line 199: lvl = "LOW"

    +1

    Done

  • Patch Set #32, Line 201: lvl = "HIGH"

    fmt. […]

    Done

  • Patch Set #32, Line 536: !isULT

    I'd flip the if/else branches to avoid the negation in the condition

    Done

To view, visit change 30890. To unsubscribe, or for help writing mail filters, visit settings.