Name of user not set #1003143 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46817 )
Change subject: tests: Add lib/edid-test test case ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46817/2/tests/include/lib/edid-test... File tests/include/lib/edid-test.h:
https://review.coreboot.org/c/coreboot/+/46817/2/tests/include/lib/edid-test... PS2, Line 7: struct edid_raw {
Shouldn't this be in src/include/edid. […]
I think not. src/include/edid.h contains public API and definitions. This struct would be used only by this test case, so I think it should not be included in src/include/edid.h.
https://review.coreboot.org/c/coreboot/+/46817/2/tests/lib/edid-test.c File tests/lib/edid-test.c:
https://review.coreboot.org/c/coreboot/+/46817/2/tests/lib/edid-test.c@1146 PS2, Line 1146: cmocka_unit_test(test_decode_edid_frame_1), : cmocka_unit_test(test_decode_edid_frame_2), : cmocka_unit_test(test_decode_edid_frame_3),
Can you name the test cases in a different way? test_device_edid_frame_2 and test_device_edid_frame_ […]
Done
https://review.coreboot.org/c/coreboot/+/46817/2/tests/stubs/console.c File tests/stubs/console.c:
https://review.coreboot.org/c/coreboot/+/46817/2/tests/stubs/console.c@22 PS2, Line 22: //return 0;
nit: please remove commented-out code
Done