View Change

3 comments:

• File tests/include/lib/edid-test.h:

  • Patch Set #2, Line 7: struct edid_raw {

    Shouldn't this be in src/include/edid. […]

    I think not. src/include/edid.h contains public API and definitions. This struct would be used only by this test case, so I think it should not be included in src/include/edid.h.

• File tests/lib/edid-test.c:

  • Patch Set #2, Line 1146:

    		cmocka_unit_test(test_decode_edid_frame_1),
    		cmocka_unit_test(test_decode_edid_frame_2),
    		cmocka_unit_test(test_decode_edid_frame_3),
    

    Can you name the test cases in a different way? test_device_edid_frame_2 and test_device_edid_frame_ […]

    Done

• File tests/stubs/console.c:

  • Patch Set #2, Line 22: //return 0;

    nit: please remove commented-out code

    Done

To view, visit change 46817. To unsubscribe, or for help writing mail filters, visit settings.