Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41621 )
Change subject: mb/asrock/e350m: Do not redefine AGESA_VERSION_STRING ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41621/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41621/1//COMMIT_MSG@7 PS1, Line 7: mb/asrock/e350m1/buildOpts.c: Fix AGESA_VERSION_STRING
Yes, and they should also be understandable. […]
Oh, right. "fix" is too generic of a word. Now I understand why you wanted me to add the version number!
https://review.coreboot.org/c/coreboot/+/41621/1//COMMIT_MSG@10 PS1, Line 10: Change it so that it matches the other AGESA f14 boards in the tree.
Angel, I am sorry for the frustration. […]
I believe I am the one who should apologize here. That was not a proper reply to a reviewer's comment. Even if I had a point there, the vitriol in my words was completely uncalled for. I am sorry that I exploded just because of such a non-critical thing.
Aaaaanyway, after having some rest, I think I found a different approach that does not rely on "fixing" that AGESA_VERSION_NUMBER macro.