View Change
2 comments:
Commit Message:
Patch Set #1, Line 7: mb/asrock/e350m1/buildOpts.c: Fix AGESA_VERSION_STRING
Yes, and they should also be understandable. […]
Oh, right. "fix" is too generic of a word. Now I understand why you wanted me to add the version number!
Patch Set #1, Line 10: Change it so that it matches the other AGESA f14 boards in the tree.
Angel, I am sorry for the frustration. […]
I believe I am the one who should apologize here. That was not a proper reply to a reviewer's comment. Even if I had a point there, the vitriol in my words was completely uncalled for. I am sorry that I exploded just because of such a non-critical thing.
Aaaaanyway, after having some rest, I think I found a different approach that does not rely on "fixing" that AGESA_VERSION_NUMBER macro.
To view, visit change 41621. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I384bd96db51457e68a320b99ecdbb2ada0dfbdd5
Gerrit-Change-Number: 41621
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel@3mdeb.com>
Gerrit-Reviewer: Michal Zygowski <miczyg94@gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 24 May 2020 09:23:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Mike Banon <mikebdp2@gmail.com>
Gerrit-MessageType: comment