Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41555 )
Change subject: mb/google/hatch/vr/puff: Setup PL2 and PsysPL2 ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41555/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41555/3/src/mainboard/google/hatch/... PS3, Line 44: #define PUFF_U62_U42_PL2 (51) It's better to use the same indentation here.
https://review.coreboot.org/c/coreboot/+/41555/3/src/mainboard/google/hatch/... PS3, Line 89: It's better to use the same indentation here.
https://review.coreboot.org/c/coreboot/+/41555/3/src/mainboard/google/hatch/... PS3, Line 130: i Keep the first line of block comment empty.