Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45630 )
Change subject: vendorcode/intel/fsp: Update Tiger Lake FSP Headers for FSP v3373 ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45630/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45630/1//COMMIT_MSG@17 PS1, Line 17: BUG=b:
@Tim, cros-bug is 169759177. […]
Done
https://review.coreboot.org/c/coreboot/+/45630/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45630/4//COMMIT_MSG@17 PS4, Line 17: b:
b:169759177
Done
https://review.coreboot.org/c/coreboot/+/45630/4//COMMIT_MSG@21 PS4, Line 21: Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com
Looks like "Cq-Depend:chrome-internal:3308203, chrome-internal:3308204, chrome-internal:3284975" lin […]
Done
https://review.coreboot.org/c/coreboot/+/45630/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45630/5//COMMIT_MSG@9 PS5, Line 9: based FSP
based on FSP
Done
https://review.coreboot.org/c/coreboot/+/45630/5//COMMIT_MSG@12 PS5, Line 12: Includes
include
Done
https://review.coreboot.org/c/coreboot/+/45630/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45630/6//COMMIT_MSG@21 PS6, Line 21: Cq-Depend:chrome-internal:3308203, chrome-internal:3308204, : chrome-internal:3284975 I'm not sure if the CQ picks them up correctly if the line is broken?