Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45278 )
Change subject: WIP: Use SPDs from PSP BIOS table type 0x69 based on GPIO straps ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45278/1/src/soc/amd/picasso/Makefil... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45278/1/src/soc/amd/picasso/Makefil... PS1, Line 265: # SPD data array blob (with SPDs for all possible memory IDs for this platform) : SPD_BLOB:=$(obj)/SPD_array.bin : : # APCB binary without SPD data : APCB_NO_SPD_BLOB:=$(FIRMWARE_LOCATE)/APCB_magic.bin
We just removed all the SPD information from the picasso Makefile and put it into the Mainboard file […]
We switched to passing APCB files to picasso. But with this change we should probably switch back to passing in SPD bins since we don't need the hacky logic for injecting SPDs into APCBs anymore.
We shouldn't need the APCB_magic.bin anymore right?
https://review.coreboot.org/c/coreboot/+/45278/1/src/soc/amd/picasso/Makefil... PS1, Line 396: :
Spaces here and on l. […]
There's an open CL for switching from hex to bin files. If you rebase on that CL this rule won't be needed: https://review.coreboot.org/c/coreboot/+/44775