View Change

2 comments:

• File src/soc/amd/picasso/Makefile.inc:

  • Patch Set #1, Line 265:

    # SPD data array blob (with SPDs for all possible memory IDs for this platform)
    SPD_BLOB:=$(obj)/SPD_array.bin
    
    # APCB binary without SPD data
    APCB_NO_SPD_BLOB:=$(FIRMWARE_LOCATE)/APCB_magic.bin
    

    We just removed all the SPD information from the picasso Makefile and put it into the Mainboard file […]

    We switched to passing APCB files to picasso. But with this change we should probably switch back to passing in SPD bins since we don't need the hacky logic for injecting SPDs into APCBs anymore.

    We shouldn't need the APCB_magic.bin anymore right?

  • Patch Set #1, Line 396: :

    Spaces here and on l. […]

    There's an open CL for switching from hex to bin files. If you rebase on that CL this rule won't be needed: https://review.coreboot.org/c/coreboot/+/44775

To view, visit change 45278. To unsubscribe, or for help writing mail filters, visit settings.