Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46090 )
Change subject: mb/google/dedede: refactor DPTF section for simpler overrides ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... PS2, Line 78: [0] = DPTF_PASSIVE(CPU, CPU, 80, 1000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 70, 4000), : [2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 75, 1000), : [3] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_2, 75, 5000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 60, 1000) nit: this would look a little cleaner if each column lined up