Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44700 )
Change subject: soc/mediatek/mt8192: Do dramc init settings ......................................................................
Patch Set 41:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44700/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44700/1/src/soc/mediatek/mt8192/dra... PS1, Line 3: #include <soc/gpio.h> : #include <soc/dramc_pi_api.h> : #include <soc/dramc_register.h> : #include <string.h> : #include <timer.h>
humm?
Ack
https://review.coreboot.org/c/coreboot/+/44700/41/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44700/41/src/soc/mediatek/mt8192/dr... PS41, Line 3: #include <soc/gpio.h> : #include <soc/dramc_pi_api.h> : #include <soc/dramc_register.h> : #include <string.h> : #include <timer.h> : Please remove unused header files and keep only the one where you declared global_option_init and dfs_init_for_calibration.