wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )
Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c File src/soc/mediatek/mt8183/gpio.c:
https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c@87 PS1, Line 87: MTK_I2C_PIN_SPEC(PAD_SCL5_ID, 20, 18),
nit: There's no need for this macro, if you want to initialize by position you can just write […]
ok,I will modify it.
https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c@98 PS1, Line 98: MTK_I2C_PIN_SPEC(PAD_SDA4_ID, 17, 12),
What do these numbers do and where do they come from? Are they specific to the board layout? Why did […]
These pins are for specific adjustment of AC-timing in order to satisfy the i2c spec(3.4MHz). 8173 only needs to meet the speed requirement of 1MHz.