Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47453 )
Change subject: util/futility: Don't refresh the binary all the time ......................................................................
util/futility: Don't refresh the binary all the time
Due to the phony dependency to check for openssl, vboot-futility was always rebuilt, and because it was newer than coreboot-futility, it was always copied over.
Do that in parallel often enough and you run into race conditions, as we did on our builders. Mark check-openssl-presence as order-only dependency so that it's executed (and can bail out) but doesn't force regeneration of vboot-futility.
Change-Id: Ib7fb798096d423d6b6cba5d199e12fe5917c3b41 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47453 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/futility/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Martin Roth: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc index ed185ce..9890339 100644 --- a/util/futility/Makefile.inc +++ b/util/futility/Makefile.inc @@ -4,7 +4,7 @@
HOSTPKGCONFIG ?= pkg-config
-$(VBOOT_FUTILITY): check-openssl-presence +$(VBOOT_FUTILITY): | check-openssl-presence @printf " MAKE $(subst $(objutil)/,,$(@))\n" unset CFLAGS LDFLAGS; $(MAKE) -C $(VBOOT_SOURCE) \ BUILD=$(VBOOT_HOST_BUILD) \