Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47453 )
Change subject: util/futility: Don't refresh the binary all the time ......................................................................
util/futility: Don't refresh the binary all the time
Due to the phony dependency to check for openssl, vboot-futility was always rebuilt, and because it was newer than coreboot-futility, it was always copied over.
Do that in parallel often enough and you run into race conditions, as we did on our builders. Mark check-openssl-presence as order-only dependency so that it's executed (and can bail out) but doesn't force regeneration of vboot-futility.
Change-Id: Ib7fb798096d423d6b6cba5d199e12fe5917c3b41 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/futility/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/47453/1
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc index ed185ce..9890339 100644 --- a/util/futility/Makefile.inc +++ b/util/futility/Makefile.inc @@ -4,7 +4,7 @@
HOSTPKGCONFIG ?= pkg-config
-$(VBOOT_FUTILITY): check-openssl-presence +$(VBOOT_FUTILITY): | check-openssl-presence @printf " MAKE $(subst $(objutil)/,,$(@))\n" unset CFLAGS LDFLAGS; $(MAKE) -C $(VBOOT_SOURCE) \ BUILD=$(VBOOT_HOST_BUILD) \
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47453 )
Change subject: util/futility: Don't refresh the binary all the time ......................................................................
Patch Set 1:
Example of the issue this should fix: https://qa.coreboot.org/job/coreboot/17487/testReport/junit/(root)/board/GOO...
mv: cannot stat '/cb-build/coreboot.0/default/sharedutils/futility/futility.tmp': No such file or directory
Not adding this to the commit message because we don't need to put noise in the permanent record, but for review an example may be helpful.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47453 )
Change subject: util/futility: Don't refresh the binary all the time ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47453 )
Change subject: util/futility: Don't refresh the binary all the time ......................................................................
Patch Set 1: Code-Review+2
Thanks Patrick
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47453 )
Change subject: util/futility: Don't refresh the binary all the time ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47453 )
Change subject: util/futility: Don't refresh the binary all the time ......................................................................
util/futility: Don't refresh the binary all the time
Due to the phony dependency to check for openssl, vboot-futility was always rebuilt, and because it was newer than coreboot-futility, it was always copied over.
Do that in parallel often enough and you run into race conditions, as we did on our builders. Mark check-openssl-presence as order-only dependency so that it's executed (and can bail out) but doesn't force regeneration of vboot-futility.
Change-Id: Ib7fb798096d423d6b6cba5d199e12fe5917c3b41 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47453 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/futility/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Martin Roth: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc index ed185ce..9890339 100644 --- a/util/futility/Makefile.inc +++ b/util/futility/Makefile.inc @@ -4,7 +4,7 @@
HOSTPKGCONFIG ?= pkg-config
-$(VBOOT_FUTILITY): check-openssl-presence +$(VBOOT_FUTILITY): | check-openssl-presence @printf " MAKE $(subst $(objutil)/,,$(@))\n" unset CFLAGS LDFLAGS; $(MAKE) -C $(VBOOT_SOURCE) \ BUILD=$(VBOOT_HOST_BUILD) \
-
Angel Pons (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)