Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46265 )
Change subject: mb/intel/adlrvp: Add ADL-P ramstage mainboard code ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46265/6/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46265/6/src/mainboard/intel/adlrvp/... PS6, Line 10: #include <string.h>
#include <stdint. […]
Ack
https://review.coreboot.org/c/coreboot/+/46265/6/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46265/6/src/mainboard/intel/adlrvp/... PS6, Line 143: PchHdaIDispLinkFrequency
for another patch: this should be an enum
Perfect, I will take a note