Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35526 )
Change subject: mb/supermicro/x11: fix cmos layout and add a default config ......................................................................
Patch Set 14: Code-Review+2
(2 comments)
Uploaded patch set 14: New patch set was added with same tree, parent, and commit message as Patch Set 13.
These ^ seem to throw Gerrit's score retention off. Usually, if you either change commit message or rebase, a +2 should stick. I guess something in your workflow unnecessarily amends commits *shrug*.
Anyway, for the future, please place such tiny fixes before the bigger, controversial ones on you branch. Then they can be faster submitted without too much rebasing noise.
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG@9 PS14, Line 9: error Is this really reported as an error somewhere? in that case that should change, a missing option in cmos.layout is not an error, more an integration choice, which options to expose.
https://review.coreboot.org/c/coreboot/+/35526/14//COMMIT_MSG@10 PS14, Line 10: missing nmi option ... update, please