Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28372 )
Change subject: riscv: update mtime initialize ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Thanks.
https://review.coreboot.org/#/c/28372/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28372/1//COMMIT_MSG@7 PS1, Line 7: riscv: update mtime initialize riscv: update mtime initialization
https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c File src/arch/riscv/mcall.c:
https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c@40 PS1, Line 40: void mtime_init(void); This function should also be declared in a header, so that SoC code can include that header and get type-checking for mtime_init.
https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c@43 PS1, Line 43: __weak void mtime_init(void) { } Consider adding a warning/error/die() message, for cases when this dummy implementation is called.
https://review.coreboot.org/#/c/28372/1/src/soc/sifive/fu540/Makefile.inc File src/soc/sifive/fu540/Makefile.inc:
https://review.coreboot.org/#/c/28372/1/src/soc/sifive/fu540/Makefile.inc@19 PS1, Line 19: bootblock-y += clint.c clint.c is not added in this commit