Thanks.

Patch set 1:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 7: riscv: update mtime initialize

    riscv: update mtime initialization

• File src/arch/riscv/mcall.c:

  • Patch Set #1, Line 40: void mtime_init(void);

    This function should also be declared in a header, so that SoC code can include that header and get type-checking for mtime_init.

  • Patch Set #1, Line 43: __weak void mtime_init(void) { }

    Consider adding a warning/error/die() message, for cases when this dummy implementation is called.

• File src/soc/sifive/fu540/Makefile.inc:

  • Patch Set #1, Line 19: bootblock-y += clint.c

    clint.c is not added in this commit

To view, visit change 28372. To unsubscribe, or for help writing mail filters, visit settings.