Sindhoor Tilak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42503 )
Change subject: post_code: replace postcode values with their respective defined constants ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42503/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42503/1//COMMIT_MSG@7 PS1, Line 7: replaced
Present tense imperative mood: Replace.
Ack
https://review.coreboot.org/c/coreboot/+/42503/1//COMMIT_MSG@9 PS1, Line 9: values
that should be one commit, as it's only replacing hardcoded numbers with defines it's easy to review […]
Ack
https://review.coreboot.org/c/coreboot/+/42503/1/src/cpu/intel/car/bootblock... File src/cpu/intel/car/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42503/1/src/cpu/intel/car/bootblock... PS1, Line 26: POST_BOOTBLOCK_SOC_EARLYINIT
does postcodes need to be send before entering a function, or after all work has been done? That sho […]
Ack
https://review.coreboot.org/c/coreboot/+/42503/1/src/mainboard/bap/ode_e21XX... File src/mainboard/bap/ode_e21XX/romstage.c:
https://review.coreboot.org/c/coreboot/+/42503/1/src/mainboard/bap/ode_e21XX... PS1, Line 31: post_code(POST_ENTRY_ROMSTAGE);
this board is not hooked up for build
Ack
https://review.coreboot.org/c/coreboot/+/42503/1/src/soc/intel/broadwell/rom... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/42503/1/src/soc/intel/broadwell/rom... PS1, Line 37: post_code(POST_ENTRY_ROMSTAGE);
move to src/cpu/intel/car/romstage. […]
Ack
https://review.coreboot.org/c/coreboot/+/42503/1/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42503/1/src/soc/intel/skylake/bootb... PS1, Line 24: POST_BOOTBLOCK_SOC_EARLYINIT
move to src/lib/bootblock. […]
Ack