6 comments:
Patch Set #1, Line 7: replaced
Present tense imperative mood: Replace.
Ack
Patch Set #1, Line 9: values
that should be one commit, as it's only replacing hardcoded numbers with defines it's easy to review […]
Ack
File src/cpu/intel/car/bootblock.c:
Patch Set #1, Line 26: POST_BOOTBLOCK_SOC_EARLYINIT
does postcodes need to be send before entering a function, or after all work has been done? That sho […]
Ack
File src/mainboard/bap/ode_e21XX/romstage.c:
Patch Set #1, Line 31: post_code(POST_ENTRY_ROMSTAGE);
this board is not hooked up for build
Ack
File src/soc/intel/broadwell/romstage/romstage.c:
Patch Set #1, Line 37: post_code(POST_ENTRY_ROMSTAGE);
move to src/cpu/intel/car/romstage. […]
Ack
File src/soc/intel/skylake/bootblock/bootblock.c:
Patch Set #1, Line 24: POST_BOOTBLOCK_SOC_EARLYINIT
move to src/lib/bootblock. […]
Ack
To view, visit change 42503. To unsubscribe, or for help writing mail filters, visit settings.