Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 95:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35523/95/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/95/src/mainboard/acer/aspire_... PS95, Line 17: select MAINBOARD_HAS_CRB_TPM : select MAINBOARD_HAS_TPM2 : # select HAVE_INTEL_PTT Schematics mention the Nuvoton NPCT650, a TPM that exists in 1.2 and 2.0 forms (I use the tpm2-tools package), and display it appearing on the LPC bus.
However, coreboot log states "Initialized TPM device Intel iTPM revision 0" with this applied. Also noting that the TPM does not work when using the vendor firmware after ME is cleaned.
I understand that CRB does not contradict LPC bus, but I'm not sure what to make of this. I'll double-check the boardview and the board itself when I get the chance, but I partially recall seeing an empty space where perhaps the boardview showed the TPM would be.