Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34872 )
Change subject: google/kukui: Load and run dram init blob ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34872/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/34872/1/src/mainboard/google/kukui/... PS1, Line 44: memset(_dram_init_code + blob_size, 0, region_size - blob_size);
Both stages and payloads get built as ELFs. […]
Done
https://review.coreboot.org/c/coreboot/+/34872/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/34872/3/src/mainboard/google/kukui/... PS3, Line 37: dram.bin
Which error codes can be returned by this binary, and what do they mean? It would be good to documen […]
We treat the blob as a prog (stage type / elf format), and prog_run() return void now. But, you are right. We should document the result of this program somewhere. In the nearly future, I guess we will get the return value from dram_params and we should document the detail in front of that struct declaration.
https://review.coreboot.org/c/coreboot/+/34872/3/src/mainboard/google/kukui/... PS3, Line 55: printk(BIOS_ERR, "dram_blob error:%d\n", err);
Please add a space after the colon, and rephrase the message, so that it understandable for the user […]
Done