3 comments:
File src/mainboard/google/kukui/romstage.c:
Patch Set #1, Line 44: memset(_dram_init_code + blob_size, 0, region_size - blob_size);
Both stages and payloads get built as ELFs. […]
Done
File src/mainboard/google/kukui/romstage.c:
Patch Set #3, Line 37: dram.bin
Which error codes can be returned by this binary, and what do they mean? It would be good to documen […]
We treat the blob as a prog (stage type / elf format), and prog_run() return void now.
But, you are right. We should document the result of this program somewhere.
In the nearly future, I guess we will get the return value from dram_params and we should document the detail in front of that struct declaration.
Patch Set #3, Line 55: printk(BIOS_ERR, "dram_blob error:%d\n", err);
Please add a space after the colon, and rephrase the message, so that it understandable for the user […]
Done
To view, visit change 34872. To unsubscribe, or for help writing mail filters, visit settings.