Attention is currently required from: Shelley Chen, Hung-Te Lin, Furquan Shaikh, Jianjun Wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56791 )
Change subject: soc/mediatek: Add PCIe support ......................................................................
Patch Set 6:
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56791/comment/866cf744_0b6e6800 PS6, Line 18: SSD Which one exactly? On what board?
Please also paste the new log messages here?
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/56791/comment/41208e41_8d41a78d PS6, Line 106: setctions sections
https://review.coreboot.org/c/coreboot/+/56791/comment/f56745e7_02fadc87 PS6, Line 111: mdelay(100); That’s pretty long for coreboot.
https://review.coreboot.org/c/coreboot/+/56791/comment/a8fc9f3f_5fa2f87c PS6, Line 122: __func__, val); Error messages should be user understandable. Please elaborate, and also document the effects.
https://review.coreboot.org/c/coreboot/+/56791/comment/b1acf4d6_b6960dbf PS6, Line 159: res->cpu_addr | PCIE_ATR_SIZE(fls(res->size))); Should fit in one line.
https://review.coreboot.org/c/coreboot/+/56791/comment/4446fb36_a4756a43 PS6, Line 174: static int mtk_pcie_dev_assign_resource(struct device *dev, Please excuse my ignorance, but what is special for assigning resources on MediaTek, that no common functions can be used?
https://review.coreboot.org/c/coreboot/+/56791/comment/7fbcf086_37d18ce6 PS6, Line 180: printk(BIOS_INFO, "res->index = %#lx\n", res->index); Looks more like debugging or spew?
https://review.coreboot.org/c/coreboot/+/56791/comment/211119b2_fcae5cfd PS6, Line 194: __func__, ctrl->mmio_io_size); Plesae add the values to error message. Also, what is the effect and what can be done about it?
https://review.coreboot.org/c/coreboot/+/56791/comment/f6476803_b9379401 PS6, Line 289: printk(BIOS_INFO, "%s: Try to probe PCIe bus\n", __func__); 1. Trying … 2. Some success or failure messages is missing?