Attention is currently required from: Shelley Chen, Hung-Te Lin, Furquan Shaikh, Jianjun Wang.
9 comments:
Commit Message:
Which one exactly? On what board?
Please also paste the new log messages here?
File src/soc/mediatek/common/pcie.c:
Patch Set #6, Line 106: setctions
sections
Patch Set #6, Line 111: mdelay(100);
That’s pretty long for coreboot.
Patch Set #6, Line 122: __func__, val);
Error messages should be user understandable. Please elaborate, and also document the effects.
Patch Set #6, Line 159: res->cpu_addr | PCIE_ATR_SIZE(fls(res->size)));
Should fit in one line.
Patch Set #6, Line 174: static int mtk_pcie_dev_assign_resource(struct device *dev,
Please excuse my ignorance, but what is special for assigning resources on MediaTek, that no common functions can be used?
Patch Set #6, Line 180: printk(BIOS_INFO, "res->index = %#lx\n", res->index);
Looks more like debugging or spew?
Patch Set #6, Line 194: __func__, ctrl->mmio_io_size);
Plesae add the values to error message. Also, what is the effect and what can be done about it?
Patch Set #6, Line 289: printk(BIOS_INFO, "%s: Try to probe PCIe bus\n", __func__);
1. Trying …
2. Some success or failure messages is missing?
To view, visit change 56791. To unsubscribe, or for help writing mail filters, visit settings.