Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42094 )
Change subject: amd/00730F01: Clean the Microcode updating. ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42094/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42094/4//COMMIT_MSG@7 PS4, Line 7: amd/00730F01: Clean the Microcode updating. Please remove the trailing dot.
https://review.coreboot.org/c/coreboot/+/42094/4//COMMIT_MSG@10 PS4, Line 10: https://review.coreboot.org/c/coreboot/+/41719 Please summarize the comments in the commit message.
https://review.coreboot.org/c/coreboot/+/42094/4//COMMIT_MSG@13 PS4, Line 13: Also, 41719 should be based on this. This should maybe be a review comment, but it doesn’t belong in the commit message. As you are also the owner of that change-set, please ensure the ordering by putting the commit into the same branch.
https://review.coreboot.org/c/coreboot/+/42094/4//COMMIT_MSG@14 PS4, Line 14: Tested how?
https://review.coreboot.org/c/coreboot/+/42094/4/src/cpu/amd/pi/00730F01/upd... File src/cpu/amd/pi/00730F01/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/42094/4/src/cpu/amd/pi/00730F01/upd... PS4, Line 131: "updates.\n"); Should fit on one line.