5 comments:
Patch Set #4, Line 7: amd/00730F01: Clean the Microcode updating.
Please remove the trailing dot.
Patch Set #4, Line 10: https://review.coreboot.org/c/coreboot/+/41719
Please summarize the comments in the commit message.
Patch Set #4, Line 13: Also, 41719 should be based on this.
This should maybe be a review comment, but it doesn’t belong in the commit message. As you are also the owner of that change-set, please ensure the ordering by putting the commit into the same branch.
Tested how?
File src/cpu/amd/pi/00730F01/update_microcode.c:
Patch Set #4, Line 131: "updates.\n");
Should fit on one line.
To view, visit change 42094. To unsubscribe, or for help writing mail filters, visit settings.