Attention is currently required from: Nico Huber, Martin Roth, Eugene Myers, Paul Menzel, Angel Pons, Michael Niewöhner. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 192:
(5 comments)
Patchset:
PS174:
- The commit message says vboot is untested but there are a lot of vboot references in the code. […]
Done
File src/mainboard/acer/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/comment/21d04286_80ae72d9 PS190, Line 15: string
This should probably go into a separate commit since it's not actually related to this patch. […]
Done. I think this was left-over from the time when I was creating the acer directory. Not anymore...
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/f8cdec2a_b574a6a4 PS190, Line 34: 0x10251037
Nit: use #defines: […]
Fair point, but 0x1025 is Acer's ID? `lspci` outputs: "Subsystem: Acer Incorporated [ALI] Device [1025:1037]".
Maybe there's a collision, or one bought the other? I don't who "AI" is.
Also, 0x1037 is a common ID for the whole system.
https://review.coreboot.org/c/coreboot/+/35523/comment/527a06a2_2416056c PS190, Line 110: ec_init(void)
Lots of magic numbers in this function that could be turned into #defines.
Right, I'll do this in a follow-up.
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/6cde158c_0a2c16c9 PS190, Line 113: Still WIP.
Maybe document what still needs to be done?
This point was partly covered by two other "TODO"s (header: find relevant SMM dispatch/callback GUIDs in the vendor firmware - mostly done, modules irrelevant; next function: finish reverse engineering the specific module relevant to EC), but I added some more detail.