chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45333 )
Change subject: soc/amd/picasso: Add UPD for support force USB3 to Gen1 by port ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG@9 PS1, Line 9: add upd usb3_port_force_gen1 for support USB3 port to gen1
Please start sentences with a capital letter and finish with a dot/period.
Done
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build,verify the USB3 speed in gen1
Please add a space after the comma.
Done
https://review.coreboot.org/c/coreboot/+/45333/8/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45333/8/src/soc/amd/picasso/chip.h@... PS8, Line 173: xhci0_force_gen1
Shouldn't this be dropped now?
I can separate a CL to remove this and use the usb3_port_force_gen1 instead.
https://review.coreboot.org/c/coreboot/+/45333/5/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45333/5/src/soc/amd/picasso/chip.h@... PS5, Line 47: xhci1_port0
yes, I add a comment for noticed the USB usage.
Done
https://review.coreboot.org/c/coreboot/+/45333/4/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45333/4/src/soc/amd/picasso/chip.h@... PS4, Line 158: uint8_t xhci0_force_gen1;
for xhci0_force_gen1,it will set all port on xhci0 to gen1 but usb3_port_force_gen1 will set it by i […]
Done