Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36791 )
Change subject: google/endeavour: add variant based on karma ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... File src/mainboard/google/fizz/variants/endeavour/gpio.c:
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... PS3, Line 22: gpio_table Is this table same as the baseboard? Or is there any difference?
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... PS3, Line 237: early_gpio_table Same question as above.
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... PS3, Line 258: __weak Why is this weak if it is being provided by the variant?
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... PS3, Line 264: __weak same here
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... PS3, Line 271: cros_gpios If baseboard is providing the same table as this, you probably don't need a separate table in the variant for cros_gpios.
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... File src/mainboard/google/fizz/variants/endeavour/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... PS3, Line 4: Inc This should be changed to LLC in all the copyright headers.
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... File src/mainboard/google/fizz/variants/endeavour/nhlt.c:
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... PS3, Line 20: __weak weak not required in variant specific file.
https://review.coreboot.org/c/coreboot/+/36791/3/src/mainboard/google/fizz/v... PS3, Line 29: __weak same here.