8 comments:
File src/mainboard/google/fizz/variants/endeavour/gpio.c:
Patch Set #3, Line 22: gpio_table
Is this table same as the baseboard? Or is there any difference?
Patch Set #3, Line 237: early_gpio_table
Same question as above.
Patch Set #3, Line 258: __weak
Why is this weak if it is being provided by the variant?
Patch Set #3, Line 264: __weak
same here
Patch Set #3, Line 271: cros_gpios
If baseboard is providing the same table as this, you probably don't need a separate table in the variant for cros_gpios.
File src/mainboard/google/fizz/variants/endeavour/include/variant/acpi/dptf.asl:
This should be changed to LLC in all the copyright headers.
File src/mainboard/google/fizz/variants/endeavour/nhlt.c:
Patch Set #3, Line 20: __weak
weak not required in variant specific file.
Patch Set #3, Line 29: __weak
same here.
To view, visit change 36791. To unsubscribe, or for help writing mail filters, visit settings.