Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48388 )
Change subject: mb/siemens/chili/base: Fix state of PCI devices ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48388/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48388/4//COMMIT_MSG@11 PS4, Line 11: to `on` is not correct. Therefore, set their state to hidden. The actual difference between on and hidden is if the device is visible during PCI enumeration. Not sure if this was misunderstood.
https://review.coreboot.org/c/coreboot/+/48388/4/src/mainboard/siemens/chili... File src/mainboard/siemens/chili/variants/base/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48388/4/src/mainboard/siemens/chili... PS4, Line 123: device pci 1f.1 hidden end # P2SB Originally, the P2SB was present during enumeration. Did this change? maybe due to an FSP update?