Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48388 )
Change subject: mb/siemens/chili/base: Fix state of PCI devices ......................................................................
mb/siemens/chili/base: Fix state of PCI devices
The PCI devices P2SB and PMC are hidden by the FSP and thus setting them to `on` is not correct. Therefore, set their state to hidden.
Change-Id: Ib7c019cd7f389b2e487829e5550cc236ee5645b7 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/siemens/chili/variants/base/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48388/1
diff --git a/src/mainboard/siemens/chili/variants/base/devicetree.cb b/src/mainboard/siemens/chili/variants/base/devicetree.cb index 6bdec65..9493801 100644 --- a/src/mainboard/siemens/chili/variants/base/devicetree.cb +++ b/src/mainboard/siemens/chili/variants/base/devicetree.cb @@ -120,8 +120,8 @@ device pnp 0c31.0 on end end end - device pci 1f.1 on end # P2SB - device pci 1f.2 on end # Power Management Controller + device pci 1f.1 hidden end # P2SB + device pci 1f.2 hidden end # Power Management Controller device pci 1f.3 on end # Intel HDA device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48388 )
Change subject: mb/siemens/chili/base: Fix state of PCI devices ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48388/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48388/2//COMMIT_MSG@9 PS2, Line 9: hidden by the FSP and thus /FSP.*thus/ -> invalid ;) That FSP does something, does not mean it is correct.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48388
to look at the new patch set (#3).
Change subject: mb/siemens/chili/base: Fix state of PCI devices ......................................................................
mb/siemens/chili/base: Fix state of PCI devices
The PCI devices P2SB and PMC are hidden by the FSP and cannot be unhidden, because the FSP locks their configuration. Thus, setting them to `on` is not correct. Therefore, set their state to hidden.
Change-Id: Ib7c019cd7f389b2e487829e5550cc236ee5645b7 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/siemens/chili/variants/base/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48388/3
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48388 )
Change subject: mb/siemens/chili/base: Fix state of PCI devices ......................................................................
Patch Set 3: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48388 )
Change subject: mb/siemens/chili/base: Fix state of PCI devices ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48388/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48388/2//COMMIT_MSG@9 PS2, Line 9: hidden by the FSP and thus
/FSP.*thus/ -> invalid ;) That FSP does something, does not mean it is correct.
Done
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48388 )
Change subject: mb/siemens/chili/base: Fix state of PCI devices ......................................................................
mb/siemens/chili/base: Fix state of PCI devices
The PCI devices P2SB and PMC are hidden by the FSP and cannot be unhidden, because the FSP locks their configuration. Thus, setting them to `on` is not correct. Therefore, set their state to hidden.
Change-Id: Ib7c019cd7f389b2e487829e5550cc236ee5645b7 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/48388 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/siemens/chili/variants/base/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/siemens/chili/variants/base/devicetree.cb b/src/mainboard/siemens/chili/variants/base/devicetree.cb index 6bdec65..9493801 100644 --- a/src/mainboard/siemens/chili/variants/base/devicetree.cb +++ b/src/mainboard/siemens/chili/variants/base/devicetree.cb @@ -120,8 +120,8 @@ device pnp 0c31.0 on end end end - device pci 1f.1 on end # P2SB - device pci 1f.2 on end # Power Management Controller + device pci 1f.1 hidden end # P2SB + device pci 1f.2 hidden end # Power Management Controller device pci 1f.3 on end # Intel HDA device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48388 )
Change subject: mb/siemens/chili/base: Fix state of PCI devices ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48388/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48388/4//COMMIT_MSG@11 PS4, Line 11: to `on` is not correct. Therefore, set their state to hidden. The actual difference between on and hidden is if the device is visible during PCI enumeration. Not sure if this was misunderstood.
https://review.coreboot.org/c/coreboot/+/48388/4/src/mainboard/siemens/chili... File src/mainboard/siemens/chili/variants/base/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48388/4/src/mainboard/siemens/chili... PS4, Line 123: device pci 1f.1 hidden end # P2SB Originally, the P2SB was present during enumeration. Did this change? maybe due to an FSP update?
-
Felix Singer (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)