Attention is currently required from: Angel Pons, xin hua wang, Nicholas Chin, Alexander Couzens.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 )
Change subject: mb/apple: Add MacBook Pro 8,1 support ......................................................................
Patch Set 23:
(6 comments)
File src/mainboard/apple/macbookpro8_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/33151/comment/92827223_4e5c7922 PS11, Line 28: config VGA_BIOS_FILE : string : default "pci8086,0126.rom" : : config VGA_BIOS_ID : string : default "8086,0126"
Needs to be extracted from vendor firmware
Let's just drop it.
File src/mainboard/apple/macbookpro8_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/33151/comment/f96e2c49_964dee87 PS16, Line 38: default 28
Um, gpio.c configures this as an input.
Yes, I'm confused here, can you look at schematics please?
File src/mainboard/apple/macbookpro8_1/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/33151/comment/b6709658_53d4c479 PS22, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
As per commit cf4722d317 (src/mb: Update unlicensable files with the CC-PDDC SPDX ID) empty files sh […]
Thanks
File src/mainboard/apple/macbookpro8_1/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/33151/comment/3167e805_a203b7d7 PS16, Line 25: gnvs->tcrt = 100; : gnvs->tpsv = 90;
I don't think these are needed.
Done
File src/mainboard/apple/macbookpro8_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33151/comment/a4280c2d_65188843 PS16, Line 52: register "pcie_port_coalesce" = "1"
Doesn't seem to be needed
Done
File src/mainboard/apple/macbookpro8_1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33151/comment/6b64757a_e1590bf5 PS11, Line 32: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, : GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
This particular wasn't, but I tested VGA BIOS on MBP 10,1 and MBA 5,2.
Let's just drop it.